Jun Zhang

Results 30 comments of Jun Zhang

We passed the whole testsuite, great! I think it's ready for the review :)

* Update the commit message * Fix `Data` is not initialized We need to another build and test @vgvassilev

After [b544a58](https://github.com/root-project/root/pull/10910/commits/b544a58d4bf17585aa596743c4e29f8aefce5385), the size of `modules.idx` almost grows 5 times larger: master branch: ``` ❯ du -h lib/modules.idx 173K lib/modules.idx ``` after [44434f0](https://github.com/root-project/root/pull/10910/commits/44434f0bb6eed7bfc8cf9edf5e93a0e4c3dc8e95) (without the fix): ``` ❯ du -h...

Maybe only register function declarations, I can see it reduce the size from `841K` to `549K`...

> @vgvassilev - I added this patch for tonight's cmssw modules IB for a test... Thank you, David! BTW how can I see the test result?

If we only care about if the identifier we look up is a top-level namespace or not, maybe we don't need to store the `DeckKind` info in GlobalModuleIndex, I plan...

> Thanks for working on this! Let's aim to merge this PR - I have added several comments. > > We might be thinking how to make the patch in...

> > If we only care about if the identifier we look up is a top-level namespace or not, maybe we don't need to store the `DeckKind` info in GlobalModuleIndex,...

Having similar issues: ``` wsl --version WSL version: 0.70.0.0 kernel version: 5.15.68.1 WSLg version: 1.0.45 MSRDC version: 1.2.3575 Direct3D version: 1.606.4 DXCore version: 10.0.25131.1002-220531-1700.rs-onecore-base2-hyp Windows version: 10.0.22621.675 ``` Running [hotspot](https://github.com/KDAB/hotspot)...