MutableArithmetics.jl icon indicating copy to clipboard operation
MutableArithmetics.jl copied to clipboard

Mk/rational arithmetic

Open kalmarek opened this issue 3 years ago • 4 comments

kalmarek avatar Feb 06 '22 19:02 kalmarek

oh, fuck; I had old version of MA in dev ;/

kalmarek avatar Feb 06 '22 19:02 kalmarek

:( This is my fault sorry. I thought it was safe to clean things up because there were no open PRs!

odow avatar Feb 06 '22 20:02 odow

ok, this looks ready from my side;

notable change:

  • use of Base.promote_op in promote_operation_fallback first and only when it fails fallback on construction of elts from their types

unfortunately I'm seeing quite some of

scalar_uniform_scaling: Test Failed at /home/kalmar/.julia/dev/MutableArithmetics/src/Test/generic.jl:6
  Expression: MA.isequal_canonical(#= /home/kalmar/.julia/dev/MutableArithmetics/src/Test/generic.jl:6 =# MA.@rewrite((x + 1) + I), (x + 1) + I)

in @rewrite with Rational{BigInt} test @blegat could you have a look?

kalmarek avatar Feb 07 '22 10:02 kalmarek

Hi. Is there any update on merging this? Better division support would be great!

hersle avatar Mar 07 '24 18:03 hersle