MutableArithmetics.jl
MutableArithmetics.jl copied to clipboard
Mk/rational arithmetic
oh, fuck; I had old version of MA in dev ;/
:( This is my fault sorry. I thought it was safe to clean things up because there were no open PRs!
ok, this looks ready from my side;
notable change:
- use of
Base.promote_opinpromote_operation_fallbackfirst and only when it fails fallback on construction of elts from their types
unfortunately I'm seeing quite some of
scalar_uniform_scaling: Test Failed at /home/kalmar/.julia/dev/MutableArithmetics/src/Test/generic.jl:6
Expression: MA.isequal_canonical(#= /home/kalmar/.julia/dev/MutableArithmetics/src/Test/generic.jl:6 =# MA.@rewrite((x + 1) + I), (x + 1) + I)
in @rewrite with Rational{BigInt} test @blegat could you have a look?
Hi. Is there any update on merging this? Better division support would be great!