JuMP.jl icon indicating copy to clipboard operation
JuMP.jl copied to clipboard

Add SHOT to list of supported solvers

Open blegat opened this issue 1 year ago • 2 comments

This doesn't check most of the item but it's the same as Couenne and BONMIN, I don't think the list applies to the solvers available through AMPLNLWriter

Basic

  • [ ] Check that the solver is a registered Julia package
  • [ ] Check that the solver supports the long-term support release of Julia
  • [ ] Check that the solver has a MathOptInterface wrapper
  • [ ] Check that the tests call MOI.Test.runtests. Some test excludes are permissible, but the reason for skipping a particular test should be documented.
  • [ ] Check that the README and/or documentation provides an example of how to use the solver with JuMP

Documentation

  • [x] Add a new row to the table in docs/src/installation.md

Optional

  • [ ] Add package metadata to docs/packages.toml

blegat avatar Oct 18 '24 08:10 blegat

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.54%. Comparing base (4876764) to head (7411809). Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3853   +/-   ##
=======================================
  Coverage   97.54%   97.54%           
=======================================
  Files          44       44           
  Lines        6027     6027           
=======================================
  Hits         5879     5879           
  Misses        148      148           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 18 '24 08:10 codecov[bot]

I've previously held off adding it because of https://github.com/jump-dev/AmplNLWriter.jl/blob/69220aff78bd769b164e960926a5947f568bff6d/test/MINLPTests/run_minlptests.jl#L72-L99

I should take another look.

odow avatar Oct 18 '24 21:10 odow

It is what it is

odow avatar Oct 23 '24 21:10 odow