Dualization.jl icon indicating copy to clipboard operation
Dualization.jl copied to clipboard

Unique names don't require underscores

Open matbesancon opened this issue 2 years ago • 1 comments

All models end up marking each variable group with _$i, even though the variables themselves are often in containers.

This typically ends up with a double indexing scheme in JuMP:

: π[6]_1 ≥ -8006.0
 : π[5]_1 ≥ -8005.0

This PR adapts it to avoid the _i if the variable name is unique

matbesancon avatar May 23 '23 19:05 matbesancon

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 :tada:

Comparison is base (14edeae) 94.73% compared to head (a00761a) 94.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #161      +/-   ##
==========================================
+ Coverage   94.73%   94.76%   +0.02%     
==========================================
  Files          13       13              
  Lines         703      707       +4     
==========================================
+ Hits          666      670       +4     
  Misses         37       37              
Impacted Files Coverage Δ
src/dual_model_variables.jl 93.39% <100.00%> (+0.25%) :arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar May 23 '23 20:05 codecov[bot]