intro-skipper icon indicating copy to clipboard operation
intro-skipper copied to clipboard

10.9 autoskip not working

Open jumoog opened this issue 1 year ago • 26 comments

It didn't worked yesterday.

jumoog avatar May 17 '24 09:05 jumoog

Today it works perfectly. I think it is a jellyfin bug the playback progress is not being reported correctly.

jumoog avatar May 17 '24 09:05 jumoog

hi, it doesn't work for me, no auto skipper or skip button, in the log I don't see any apparent error, it analyzes the libraries well however, I should never have done the new jellyfin update, because before everything worked very well

FuZion45 avatar May 17 '24 10:05 FuZion45

I have recently updated to 10.9.1, intro skipper to 2.0.4. Auto skip works fine but there is no skip intro button displayed. :(

Chat-mots avatar May 18 '24 00:05 Chat-mots

I have recently updated to 10.9.1, intro skipper to 2.0.4. Auto skip works fine but there is no skip intro button displayed. :(

That should be resolved in the next update/

AbandonedCart avatar May 18 '24 00:05 AbandonedCart

I have recently updated to 10.9.1, intro skipper to 2.0.4. Auto skip works fine but there is no skip intro button displayed. :(

I was able to get the skippe auto to work last night, this morning when I got up it no longer works, the plugin seems not stable it seems

FuZion45 avatar May 18 '24 11:05 FuZion45

I have recently updated to 10.9.1, intro skipper to 2.0.4. Auto skip works fine but there is no skip intro button displayed. :(

I was able to get the skippe auto to work last night, this morning when I got up it no longer works, the plugin seems not stable it seems

I noticed the same problem. after some time the client does not report back the correct play position. But the plugin needs the correct play position to skip the intro.

jumoog avatar May 18 '24 11:05 jumoog

I have recently updated to 10.9.1, intro skipper to 2.0.4. Auto skip works fine but there is no skip intro button displayed. :(

I was able to get the skippe auto to work last night, this morning when I got up it no longer works, the plugin seems not stable it seems

I noticed the same problem. after some time the client does not report back the correct play position. But the plugin needs the correct play position to skip the intro.

ok, is there a solution to fix this? or a future update of the plugin in the coming days?

FuZion45 avatar May 18 '24 11:05 FuZion45

Working for 10.9.2.

On Android tv it's now auto playing next episode, before the next up screen would show/

VampiricAlien avatar May 18 '24 11:05 VampiricAlien

Working for 10.9.2.

On Android tv it's now auto playing next episode, before the next up screen would show/

i'll restore the old funktion

jumoog avatar May 18 '24 12:05 jumoog

2024-05-18T18:18:49.870191253Z [20:18:49] [ERR] [44] Emby.Server.Implementations.Session.SessionManager: Error reporting playback progress
2024-05-18T18:18:49.870219822Z System.ObjectDisposedException: Cannot access a disposed object.
2024-05-18T18:18:49.870223482Z Object name: 'Emby.Server.Implementations.Session.SessionManager'.
2024-05-18T18:18:49.870226562Z    at Emby.Server.Implementations.Session.SessionManager.OnPlaybackProgress(PlaybackProgressInfo info, Boolean isAutomated)
2024-05-18T18:18:49.870229652Z    at MediaBrowser.Controller.Session.SessionInfo.OnProgressTimerCallback(Object state)
2024-05-18T18:18:50.161235517Z [20:18:50] [ERR] [44] Emby.Server.Implementations.Session.SessionManager: Error reporting playback progress
2024-05-18T18:18:50.161259807Z System.ObjectDisposedException: Cannot access a disposed object.
2024-05-18T18:18:50.161262077Z Object name: 'Emby.Server.Implementations.Session.SessionManager'.
2024-05-18T18:18:50.161264547Z    at Emby.Server.Implementations.Session.SessionManager.OnPlaybackProgress(PlaybackProgressInfo info, Boolean isAutomated)
2024-05-18T18:18:50.161266497Z    at MediaBrowser.Controller.Session.SessionInfo.OnProgressTimerCallback(Object state)
2024-05-18T18:18:50.870710330Z [20:18:50] [ERR] [64] Emby.Server.Implementations.Session.SessionManager: Error reporting playback progress
2024-05-18T18:18:50.870727799Z System.ObjectDisposedException: Cannot access a disposed object.
2024-05-18T18:18:50.870730579Z Object name: 'Emby.Server.Implementations.Session.SessionManager'.
2024-05-18T18:18:50.870732999Z    at Emby.Server.Implementations.Session.SessionManager.OnPlaybackProgress(PlaybackProgressInfo info, Boolean isAutomated)
2024-05-18T18:18:50.870735449Z    at MediaBrowser.Controller.Session.SessionInfo.OnProgressTimerCallback(Object state)
2024-05-18T18:18:51.161833603Z [20:18:51] [ERR] [64] Emby.Server.Implementations.Session.SessionManager: Error reporting playback progress
2024-05-18T18:18:51.161868232Z System.ObjectDisposedException: Cannot access a disposed object.
2024-05-18T18:18:51.161873112Z Object name: 'Emby.Server.Implementations.Session.SessionManager'.
2024-05-18T18:18:51.161877582Z    at Emby.Server.Implementations.Session.SessionManager.OnPlaybackProgress(PlaybackProgressInfo info, Boolean isAutomated)
2024-05-18T18:18:51.161881572Z    at MediaBrowser.Controller.Session.SessionInfo.OnProgressTimerCallback(Object state)
2024-05-18T18:18:51.869047618Z [20:18:51] [ERR] [64] Emby.Server.Implementations.Session.SessionManager: Error reporting playback progress
2024-05-18T18:18:51.869078278Z System.ObjectDisposedException: Cannot access a disposed object.
2024-05-18T18:18:51.869093537Z Object name: 'Emby.Server.Implementations.Session.SessionManager'.
2024-05-18T18:18:51.869095867Z    at Emby.Server.Implementations.Session.SessionManager.OnPlaybackProgress(PlaybackProgressInfo info, Boolean isAutomated)
2024-05-18T18:18:51.869097927Z    at MediaBrowser.Controller.Session.SessionInfo.OnProgressTimerCallback(Object state)
2024-05-18T18:18:52.160100883Z [20:18:52] [ERR] [64] Emby.Server.Implementations.Session.SessionManager: Error reporting playback progress
2024-05-18T18:18:52.160139252Z System.ObjectDisposedException: Cannot access a disposed object.
2024-05-18T18:18:52.160145592Z Object name: 'Emby.Server.Implementations.Session.SessionManager'.
2024-05-18T18:18:52.160151451Z    at Emby.Server.Implementations.Session.SessionManager.OnPlaybackProgress(PlaybackProgressInfo info, Boolean isAutomated)
2024-05-18T18:18:52.160157561Z    at MediaBrowser.Controller.Session.SessionInfo.OnProgressTimerCallback(Object state)

jumoog avatar May 18 '24 18:05 jumoog

Its a Jellyfin bug

jumoog avatar May 18 '24 18:05 jumoog

Working for 10.9.2. On Android tv it's now auto playing next episode, before the next up screen would show/

i'll restore the old funktion

it's in v0.2.0.5

jumoog avatar May 18 '24 18:05 jumoog

Solved my issue on windows. For those who are confused if the plugin has enough permissions, activate the full debug logs and be sure introskipper has the permission to modify html ! @FuZion45

Chat-mots avatar May 18 '24 20:05 Chat-mots

Any additional steps required for a docker env?

pomee4 avatar May 18 '24 20:05 pomee4

How would you modify permissions for introskipper for docker?

xManvir avatar May 18 '24 20:05 xManvir

Any additional steps required for a docker env?

How would you modify permissions for introskipper for docker?

See https://github.com/jumoog/intro-skipper/issues/104

AbandonedCart avatar May 18 '24 21:05 AbandonedCart

The seek command was sent but I don't see a message in the websocket

2024-05-20T11:24:07.620422975Z [13:24:07] [INF] [47] ConfusedPolarBear.Plugin.IntroSkipper.AutoSkip: Playback position is 357, intro runs from 354.68699999999995 to 381.88939999999997

2024-05-20T11:24:07.620486503Z [13:24:07] [INF] [47] ConfusedPolarBear.Plugin.IntroSkipper.AutoSkip: Sending seek command to TW96aWxsYS81LjAgKFdpbmRvd3MgTlQgMTAuMDsgV2luNjQ7IHg2NDsgcnY6MTI2LjApIEdlY2tvLzIwMTAwMTAxIEZpcmVmb3gvMTI2LjB8MTcxNjIwMjgwMzQ3Ng11

grafik

jumoog avatar May 20 '24 11:05 jumoog

When this happens, I can't control the session from the Jellyfin dashboard.

jumoog avatar May 20 '24 12:05 jumoog

I have opened an issue here: https://github.com/jellyfin/jellyfin/issues/11755

jumoog avatar May 20 '24 13:05 jumoog

Hi, I finally got mine working again. I had to Erase all introduction/end credits timestamps. I think something got messed up with the cache when I updated.

saydo17 avatar May 21 '24 03:05 saydo17

I had the same problem! A bunch of my intro timestamps were showing as IntroEnd 0, making them invalid.

grafik

rlauuzo avatar May 21 '24 06:05 rlauuzo

@saydo17 how can you do the cleanup?

ramonskie avatar May 21 '24 07:05 ramonskie

@saydo17 how can you do the cleanup?

Under the Advanced section of the config, open the Manage Fingerprints section. There are two buttons at the bottom. I ran the detect intros and credits task again after.

saydo17 avatar May 21 '24 08:05 saydo17

I had the same problem! A bunch of my intro timestamps were showing as IntroEnd 0, making them invalid.

Exact same thing for me!

saydo17 avatar May 21 '24 08:05 saydo17

This may be related to the changes made to https://github.com/jumoog/intro-skipper/commit/03af05c3c6fd7090d8ad851924e8717d31b2cd26. I also had to adjust the timing of the unit tests.

jumoog avatar May 21 '24 09:05 jumoog

https://github.com/jumoog/intro-skipper/pull/177 maybe fixes it

rlauuzo avatar May 21 '24 09:05 rlauuzo

Okay, I'm running the Android TV app v0.16.10 in the Android TV Emulator and I can't control the session from the Jellyfin Dashboard. I can't see the sent messages.

//Update: I build the App from master branch and that Versions seems to work.

jumoog avatar May 23 '24 11:05 jumoog

As a plugin, we can't do more than send the command to seek. Unfortunately, we cannot do anything about whether it reaches the client.

jumoog avatar May 26 '24 20:05 jumoog

@jumoog does this mean the android skip button will only show if i build the android tv jellyfin from the master branch?

ramonskie avatar May 27 '24 09:05 ramonskie

No the skip button is not supported by the official Android TV app.

jumoog avatar May 27 '24 09:05 jumoog