intro-skipper icon indicating copy to clipboard operation
intro-skipper copied to clipboard

[Feature Request] - Native jellyfin next card

Open PeachesMLG opened this issue 1 year ago • 5 comments

Feature Request: Native jellyfin next card

If the time after we skip the ending credits is less than (10 seconds?) would it be possible to show the default jellyfin ending card rather than the next button? image image

PeachesMLG avatar May 12 '24 18:05 PeachesMLG

Being relatively new to jellyfin, I could be wrong. I have a feeling that is part of internal code and not necessarily something exposed to plugins for use. I have a feeling the closest would be a replica.

AbandonedCart avatar May 12 '24 20:05 AbandonedCart

@AbandonedCart This is already a working feature however when the plugin skips the ending it stops playback, this will allow it to play the next item and skip the outro.

VampiricAlien avatar May 12 '24 22:05 VampiricAlien

I think you misunderstood. I was saying I don't think we, as a plugin, have any control over that, as a core feature of jellyfin. You would likely have to either skip to just before that is triggered to trigger it or replicate the UI design to replace it.

AbandonedCart avatar May 12 '24 22:05 AbandonedCart

I understood what you was saying, Was checking to see if something like this was possible at the plugin end automatically. Was a good idea @PeachesMLG had.

VampiricAlien avatar May 12 '24 22:05 VampiricAlien

I still get the feeling there is some confusion because I wasn't saying it was a bad idea. I was saying we'd likely need to create a replacement because I doubt we have the option to make it appear on command.

AbandonedCart avatar May 12 '24 22:05 AbandonedCart

is this still needed in 10.10 with native support?

jumoog avatar Nov 06 '24 19:11 jumoog

@jumoog I'm here from #220 - with the native "skip intro" and "next" buttons, currently both of them show up if there's an intro segment in the file, which is somewhat irritating (and looks really messy):

Screenshot 2024-11-21 at 03 29 15

In connection to your question, what are the future plans for intro-skipper? The native implementation seems to be a bit of a mess right now, and there's only the chapter-based plugin. Is the plan for intro-skipper to provide audio fingerprint based chapter detection that integrates into Jellyfin's native chapter segment implementation? I'd love to see that for functionality and uniformity :D

alvitali avatar Nov 21 '24 02:11 alvitali

There's a lot to unpack here, so here goes...

  1. Disable one of the two options. The easiest of which being to go into the plugin settings, disable the button, and restart the server. It should have disabled itself when you updated, but some people have accidentally went ahead and enabled it again.
  2. It is an alternative to the chapter provider. At some point, installing both side by side will be possible and then you can prioritize them. More information on that is available on jellyfin
  3. The future of the plugin is now. It already supports the new API. That is evident from having both buttons. If the plugin didn't support the segments, you wouldn't see a button for them.

AbandonedCart avatar Nov 21 '24 04:11 AbandonedCart

Is the plan for intro-skipper to provide audio fingerprint based chapter detection that integrates into Jellyfin's native chapter segment implementation?

What do you mean by audio fingerprint based chapter detection? We already use audio fingerprinting to detect the intro and store the timings using the new Media Segment API.

jumoog avatar Nov 21 '24 09:11 jumoog

Thanks for your detailed reply! Not everything is clear to me yet though;

  1. Disable one of the two options. The easiest of which being to go into the plugin settings, disable the button, and restart the server.

Which button should I disable? The intro-skipper one? The native Jellyfin one it seems can only be disabled per user / client individually.

  1. The future of the plugin is now. It already supports the new API. That is evident from having both buttons. If the plugin didn't support the segments, you wouldn't see a button for them.

I'm sorry, I figured the mechanism remained the same, as the plugin doesn't seem to store the chapter data in jellyfin's library / db yet. This means clients (at least those where the media segments have been implemented ^^) can use the segments provided by intro-skipper as well?

What do you mean by audio fingerprint based chapter detection? We already use audio fingerprinting to detect the intro and store the timings using the new Media Segment API.

@jumoog That's what I meant! Sorry for not being clear enough. As intro-skipper is the only plugin providing audio fingerprint based chapter detection, but it seemed to me it didn't integrate into the server as well as the "native" / jellyfin-maintained plugin.

Edit: Disabled the intro-skipper button, thanks. Does this also mean I don't have to run the Jellyfin container as root anymore, as the button doesn't need to be injected into jellyfin-web anymore? I was looking into setting up a script with this solution from #198, this would be much better of course

Thank you for all your work on the plugin and your support! :)

alvitali avatar Nov 21 '24 14:11 alvitali

Which button should I disable? The intro-skipper one? The native Jellyfin one it seems can only be disabled per user / client individually.

The easiest of which being to go into the plugin settings, disable the button, and restart the server.

^ This was the plugin button.

I'm sorry, I figured the mechanism remained the same, as the plugin doesn't seem to store the chapter data in jellyfin's library / db yet. This means clients (at least those where the media segments have been implemented ^^) can use the segments provided by intro-skipper as well?

The mechanism is the same, but with the added layer of supporting segments. The only difference between then and now is we used to store the data in the plugin. Now it's stored in jellyfin. You used to need the plugin to inject a button, but now one can be enabled in jellyfin. The easiest way to think of it is that the UI moved into the clients.

Edit: Disabled the intro-skipper button, thanks. Does this also mean I don't have to run the Jellyfin container as root anymore, as the button doesn't need to be injected into jellyfin-web anymore? I was looking into setting up a script with this solution from #198, this would be much better of course

You can stop running it as root if you like.

AbandonedCart avatar Nov 21 '24 15:11 AbandonedCart

Closing this one, since it's not a decision for the plugin anymore.

AbandonedCart avatar Dec 13 '24 17:12 AbandonedCart