OpenID-Connect-PHP icon indicating copy to clipboard operation
OpenID-Connect-PHP copied to clipboard

$verifiedClaims is no array but an object

Open tillweb opened this issue 7 months ago • 0 comments

Since member $verifiedClaims is an (deserialized json) object and no associative array it should not be declared as array [].

https://github.com/jumbojett/OpenID-Connect-PHP/blob/1a468a40175e6d3366328678309623985ca2b150/src/OpenIDConnectClient.php#L199

e.g.

var $verifiedClaims;

or

private ?object $verifiedClaims;

I assume an default initialization is not necessary but this needs to be checked by the author.

Since the member is overwritten by on object always before use, it does not matter in terms of functionality but it is just not nice.

tillweb avatar Jul 22 '24 08:07 tillweb