pre-commit-hooks icon indicating copy to clipboard operation
pre-commit-hooks copied to clipboard

shfmt pre-commit hook fails on files with spaces in path

Open robert914 opened this issue 2 years ago • 0 comments

The shfmt pre-commit hook fails if the file path contains spaces. The issue is that these lines in: https://github.com/jumanjihouse/pre-commit-hooks/blob/master/pre_commit_hooks/shfmt

readonly cmd="shfmt -w $*"
echo "[RUN] ${cmd}"
${cmd}

should probably instead be something like:

readonly cmd=(shfmt "-w" "$@")
echo "[RUN] ${cmd[@]}"
"${cmd[@]}"

To properly handle spaces in paths. Thanks!

robert914 avatar Mar 18 '22 18:03 robert914