android-mpesa-api icon indicating copy to clipboard operation
android-mpesa-api copied to clipboard

Migrate from Dagger to KOIN

Open jumaallan opened this issue 4 years ago • 8 comments

Migrate the DI setup to KOIN, from Dagger

jumaallan avatar Feb 04 '21 12:02 jumaallan

I think for the sample project, we should not use any DI. This will make the example easy to use by anyone who wants to learn how the library works

jumaallan avatar Aug 19 '21 12:08 jumaallan

I think for the sample project, we should not use any DI. This will make the example easy to use by anyone who wants to learn how the library works

with this in mind you should probably close this issue

wangerekaharun avatar Aug 20 '21 07:08 wangerekaharun

This issue was meant to change the DI inside the library module itself, not the sample app

jumaallan avatar Aug 20 '21 09:08 jumaallan

Seen the library module doesn't have any DI

wangerekaharun avatar Aug 20 '21 09:08 wangerekaharun

Yeah, the re-write was going to use KOIN maybe, or we can just do away with the DI concept on the module

jumaallan avatar Aug 20 '21 13:08 jumaallan

@andronicus-kim Feel free to contribute to this conversation

jumaallan avatar Aug 20 '21 14:08 jumaallan

I think introducing DI on the module will make it a lot cleaner.

andronicus-kim avatar Aug 20 '21 14:08 andronicus-kim

Great. Let's continue working from your current PR

jumaallan avatar Aug 20 '21 14:08 jumaallan