nextcloud-docker-dev icon indicating copy to clipboard operation
nextcloud-docker-dev copied to clipboard

Change the subnet var

Open zak39 opened this issue 3 years ago • 2 comments

With the subnet hard-coded, this cloud cause an error with the user's / developer's local network.

So, it's not a good practice to write the hard-code the subnet and use a common private IP distributed by our modems.

I added the "draft" label because, I don't success to log in with the user1 and user2 accounts. But, I can log in with the admin account.

I don't know if this problem is related to my changes.

zak39 avatar Oct 07 '22 15:10 zak39

I just tried on the master branch and I have the same problem with the accounts user1, user2, etc.

zak39 avatar Oct 07 '22 15:10 zak39

I removed the draft label. Because the user account problems are not related to my PR

zak39 avatar Oct 08 '22 06:10 zak39

A hardcoded subnet is also a problem for running multiple separated instances (for example, master + stable).

ShGKme avatar Mar 31 '23 15:03 ShGKme

Multiple versions can be ran in parallel using the separate containers within the same docker compose project. They should all use the same subnet

juliusknorr avatar Apr 04 '23 08:04 juliusknorr

I think the currently available option to specify a subnet that does not conflict with your local setup should be enough. You can already put a custom one as DOCKER_SUBNET=192.168.111.0/24 in your .env file. I'd like to keep this fixed as having a personal fixed subnet is sometimes useful to not need to lookup an IP and I don't see a huge benefit of always creating a new one. Anyways thanks for the PR :)

juliusknorr avatar Dec 03 '23 13:12 juliusknorr