dreamer-pytorch icon indicating copy to clipboard operation
dreamer-pytorch copied to clipboard

Very minor bug in RSSM

Open alec-tschantz opened this issue 4 years ago • 1 comments

Very minor (and I may have misunderstood): I believe the input to the stochastic_prior_model in the RSSMTransition class should be deterministic_size rather than hidden_size (line 76 in rnns.py).

This doesn't cause any errors at the moment as these default to the same value (200). But I see no reason why these have to be the same - one is the hidden size of the RNN, and the other is a generic size for hidden nodes in the model.

alec-tschantz avatar Nov 20 '20 19:11 alec-tschantz

Thanks for finding this! If you want, you can make a pull request with the small change!

juliusfrost avatar Nov 20 '20 20:11 juliusfrost