Julie Vogelman

Results 227 comments of Julie Vogelman

Okay, yes, those sometimes fail intermittently. Sorry for the hassle but can you submit [empty commits](https://www.freecodecamp.org/news/how-to-push-an-empty-commit-with-git/) until everything passes and then let me know?

I'm surprised but I've just become aware that the Argo Server deletes Pods as part of `RetryWorkflow()` ([here](https://github.com/argoproj/argo-workflows/blob/main/server/workflow/workflow_server.go#L399)). I figured it was something that would only be the role of...

Would you mind adding to the Description more information on how you decided on your approach and your investigation of corner cases?

Here's another case: let's say that somebody is prematurely deleting their Workflow before it's done. We want to make sure the Finalizer gets removed from the Pods. I'm not sure...

Hey @isubasinghe - would you be interested in also reviewing this PR? I believe you may have worked on pod deletion-related PRs unless I’m mistaken?

Thank you @sakai-ast ! I apologize on all the iterations, including potentially needing to add back code that we decided to remove. I agree on the feature flag really helping...

> @juliev0 Yeah I did do some work on pod deletion I think, I can have a look now. Appreciate it. Thanks! Note that there is a feature flag for...

Thank you so much for all of the testing @sakai-ast . Do you remember the functionality that was in this PR that we decided to remove in the `DeleteFunc` from...

> @juliev0 I have re-added the finalizer removal logic in the `DeleteFunc` [b1c54ac](https://github.com/argoproj/argo-workflows/commit/b1c54ac8f28e855573690330a55610e4dcc49002) > > and the following issue has resolved. > > [...] > > How did you notice...

@sonbui00 sorry this ended up being delayed. I see @isubasinghe approved this awhile back. @isubasinghe is now an Approver and can merge. Do you want to fix the merge conflicts...