play-json-derived-codecs icon indicating copy to clipboard operation
play-json-derived-codecs copied to clipboard

Modified project to cross-compile to scala 3 and 2

Open javierfvargas opened this issue 1 year ago • 2 comments
trafficstars

Proposal for scala 3 using macros instead of shapeless.

I'd suggest moving sbt version even upward and as part of my ignorance I added this line

ThisBuild / version := "11.0.0-local"

Of course it has to be removed, just left it there so that you can check it locally.

If you guide me on your coding standards I am happy to help. Maybe insteade of requesting this PR to master you could create a mirror branch and we work on a PR to that branch.

javierfvargas avatar Nov 12 '24 18:11 javierfvargas

Thank you @javierfvargas for opening the PR! I didn’t have a look at the implementation yet but it seems there is a test failure:

https://github.com/julienrf/play-json-derived-codecs/actions/runs/11803446878/job/33012046622?pr=97#step:6:126

It looks like the discriminator name is not correct. Could you please investigate this CI failure?

julienrf avatar Nov 17 '24 13:11 julienrf

@julienrf pls have a little patience. I am traveling with my company and additionally I found some issues when I decided to switch to a more recent scala version. It seems the compiler got stricter and requires the code to be different. I think it is a good idea to understand what should be different and be sure to include it in advance.

javierfvargas avatar Nov 19 '24 20:11 javierfvargas