julienrbrt

Results 459 comments of julienrbrt

> I'm disappointed by the change to require a checksum on URLs. It's needlessly opinionated and makes cosmovisor unusable for us (Provenance). This is why I wanted to check if...

Last requested feature just got merged: https://github.com/cosmos/cosmos-sdk/pull/16919 Going to start testing Cosmovisor changes next week and release v1.5.0.

If the naming is okay, can you run `make proto-swagger-gen`?

Usually, plans contain a binary url as well: https://www.mintscan.io/umee/proposals/91, so you _could_ assume a tag from there. However, this is correct that it may not be the most reliable. I...

This has never worked with comma separated before, maybe the `Use` of the example could be more precise.

> But, I feel UX wise comma separated would be more helpful, isn't it? what do you think if we could make the command to work as per the description??...

If saving and reusing caches does not work, we could as well use the diff of the PR and run linting only on the touched packages. This may as well...

> because in the past the technique you've described has led to "grandfathering" in linter issues The thing is, unless you bump golangci-lint, running on the touched files would work....

> So, per your request I won't make those changes, but I do think they are related. Golangci-lint will pick up everything in a workspace. The issue is about not...