Julien Truffaut

Results 79 comments of Julien Truffaut

@VladUreche thanks for looking into that. A few points, I would not rely on benchmarking with loops and `System.currentTimeMillis` it is very easy to get biased result. I will rerun...

@VladUreche no problem take your time, I just wanted to be sure that we agreed on the importance of this issue. Indeed scala list uses some tricks but we can...

@kenbot btw I know that all Monocle blackbox macros have been ported in dotty, need to find the link

I am notoriously bad with names but I have a slight preference for `from`

@kenbot what's the `get` in your example? Shouldn't it be `x` as `Some` is defined like: ``` final case class Some[+A](x: A) extends Option[A] ```

potentially we could make this improvement in `GenLens`

you can achieve the same result using with `Prism`, e.g. ``` scala jIntPrism.modify(_ + 10)(jNumber(10)) == jNumber(20) ```

why not use `asRightT` to be similar to `asRight` for `Either` syntax

I started some experiment in the variance branch, e.g. https://github.com/julien-truffaut/Monocle/tree/variance/core/shared/src/main/scala/monocle/poly

@joroKr21 good point, thanks for calling me bluff! I was so sure it wouldn't work that I didn't check. By curiosity, why do you think it is better to keep...