integration_onedrive icon indicating copy to clipboard operation
integration_onedrive copied to clipboard

Fix: download retry handler

Open bigcat88 opened this issue 1 year ago • 1 comments

As proposed in this issue https://github.com/nextcloud/integration_onedrive/issues/47#issuecomment-2291208701 by @baywet we are adding retry handler with help of KiotaMiddleware

bigcat88 avatar Sep 23 '24 11:09 bigcat88

Then only changed part is this:

private function getKiotaHandlerStack(): HandlerStack {
    $handlerStack = HandlerStack::create();
    $handlerStack->push(KiotaMiddleware::retry(), RetryHandler::HANDLER_NAME);
    return $handlerStack;
}

$options = [
    'stream' => true,
    'timeout' => 0,
    'headers' => [
        'User-Agent' => 'Nextcloud Dropbox integration',
    ],
    'handler' => $this->getKiotaHandlerStack(),  # this one!
];

in fileRequest and usual request (that handles calendar, contacts and directory listing)

bigcat88 avatar Sep 23 '24 11:09 bigcat88

Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

github-actions[bot] avatar Nov 05 '24 02:11 github-actions[bot]