python-mysql-replication icon indicating copy to clipboard operation
python-mysql-replication copied to clipboard

Use a simplifed byte2int

Open julien-duponchelle opened this issue 9 years ago • 4 comments

It's offer a very small performance gain

The original implementation from PyMySQL test instance type before. https://github.com/PyMySQL/PyMySQL/blob/3be54819ee6b09710be892a2b86f4592eaabf412/pymysql/util.py

It's not require and by dropping it's a little faster.

julien-duponchelle avatar Sep 27 '14 14:09 julien-duponchelle

hm, this breaks the tests. Otherwise it's okay for me :)

bjoernhaeuser avatar Sep 27 '14 16:09 bjoernhaeuser

Hmm with Python 3 and Python 2 we don't have the same result .. I'm not sure to understand why.

julien-duponchelle avatar Sep 27 '14 18:09 julien-duponchelle

Not really sure about this fix.

julien-duponchelle avatar Sep 27 '14 18:09 julien-duponchelle

Hm, I dont like it.

bjoernhaeuser avatar Mar 28 '15 17:03 bjoernhaeuser