docker-osx icon indicating copy to clipboard operation
docker-osx copied to clipboard

allow the vagrant box to be configurable

Open mmerickel opened this issue 10 years ago • 7 comments

mmerickel avatar May 17 '14 03:05 mmerickel

What's the use of this? docker-0.8.0 is the only box that exists.

bfirsh avatar May 18 '14 11:05 bfirsh

Ah well I had a box that's still using the docker-0.7.2 image and encountered some errors when using the newer scripts, so I used this to stay on 0.7.2 for now. The main issue is that the VAGRANT_BOX_URL param introduced in #57 wasn't really useful without this part.

mmerickel avatar May 18 '14 20:05 mmerickel

Ah, okay. You should in theory be able to set VAGRANT_BOX_URL to http://static.orchardup.com/binaries/vagrant/vagrant-docker-0.7.2-virtualbox.box?

bfirsh avatar May 21 '14 11:05 bfirsh

Right, but without this PR you cannot tell docker-osx to boot a different box since the URL is only used when your machine doesn't have a box downloaded named docker-0.8.0 right now.

mmerickel avatar May 21 '14 18:05 mmerickel

Ah sorry, I understand what you mean. Perhaps we could just rename the box "docker" – once you've downloaded it, it automatically updates the Docker version for you.

bfirsh avatar May 22 '14 10:05 bfirsh

:+1: I don't have an immediate use for this, but I could see it being useful to be able to use two different versions of Docker.

freewil avatar Jun 19 '14 05:06 freewil

I've rebased this onto master. If you'd like to rename the box to "docker" that's fine but it's orthogonal to this PR which allows someone to use any box if necessary.

mmerickel avatar Jul 04 '14 22:07 mmerickel