2018DDDMappings icon indicating copy to clipboard operation
2018DDDMappings copied to clipboard

Microsoft.EntityFrameworkCore 2.1 is released :-)

Open The-real-Urb opened this issue 7 years ago • 2 comments

The-real-Urb avatar May 31 '18 17:05 The-real-Urb

hi there. I expect to see version #s change in csproj files and I see your new unit tests . But the diff is showing me large swaths of changes across the cs files.

I'm happy to have the new package versions, but don't want to take anything else without some explanations perhaps in the form of issues? I use this for my demos and your additions ..ala syncing playsers...gives me more logic I have to explain which can be challenging in limited time. Can you do separate PRs for each type of change you made?

Thanks

Otherwise, I'll just update the packages from RC1 to RTM (and thanks for reminding me about that!)

julielerman avatar Jun 09 '18 16:06 julielerman

Hi Julie,

I forgot to create a new branch after creating the pullrequest. So I noticed and abandonned the pullrequest. My bad :-/

I did learn some other things as well from your code example 😉

Greetings,

Stefaan

Op 9 jun. 2018 18:53 schreef "Julie Lerman" [email protected]:

hi there. I expect to see version #s change in csproj files and I see your new unit tests . But the diff is showing me large swaths of changes across the cs files.

I'm happy to have the new package versions, but don't want to take anything else without some explanations perhaps in the form of issues? I use this for my demos and your additions ..ala syncing playsers...gives me more logic I have to explain which can be challenging in limited time. Can you do separate PRs for each type of change you made?

Thanks

Otherwise, I'll just update the packages from RC1 to RTM (and thanks for reminding me about that!)

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/julielerman/2018DDDMappings/pull/1#issuecomment-395983658, or mute the thread https://github.com/notifications/unsubscribe-auth/ADN8bPb1Wx69NxvV54mfb1yuIPd0iubxks5t6_2ggaJpZM4UVaIH .

The-real-Urb avatar Jun 10 '18 14:06 The-real-Urb