npc-lib icon indicating copy to clipboard operation
npc-lib copied to clipboard

Don't shade packetevents

Open vytskalt opened this issue 2 years ago • 3 comments

I think it would be great if packetevents wasn't shaded in the library and it was up to the user to do so. In my case I already depend on ProtocolLib in my plugin so I don't need packetevents to be included.

vytskalt avatar Sep 05 '23 13:09 vytskalt

I will try to take a look into publishing a version with and one without packetevents shaded soon-ish.

derklaro avatar Oct 05 '23 10:10 derklaro

@derklaro you can split the packetevents implementation into another module so people can still use that with adding new module's dependency.

portlek avatar Oct 06 '23 01:10 portlek

Or it could use compileOnly on packetevents and then check at runtime if packetevents is in the classpath. This way it would also be possible to use the standalone packetevents plugin

vytskalt avatar Oct 06 '23 04:10 vytskalt

Starting with beta8 there is no longer anything shaded.

derklaro avatar Aug 17 '24 23:08 derklaro