mobile_scanner icon indicating copy to clipboard operation
mobile_scanner copied to clipboard

Published 20 hours ago • verified publisher icon juliansteenbakker

fix: Switch to iOS 13, use Tasks to handle threads and add error handling

Open juliansteenbakker opened this issue 1 year ago • 4 comments

Continuation of #726

juliansteenbakker avatar Dec 12 '23 21:12 juliansteenbakker

Any updates on this PR ? @juliansteenbakker

yeras-is avatar Dec 19 '23 11:12 yeras-is

Since this PR needs a minimum of iOS 13, i am working on a implementation that also enabled iOS 12 to work. @yeras-is

juliansteenbakker avatar Dec 19 '23 11:12 juliansteenbakker

I have got this working right now, however, im not yet convinced if this is an improvement over the existing features. I'm not quite familiar with swift async programming and completion, so i can't really point out the advantage over each other. @navaronbracke do you have any idea's about if this change is really an improvement, or will just clutter the existing codebase more?

juliansteenbakker avatar Dec 19 '23 13:12 juliansteenbakker

I'm not that familiar with Tasks in Swift, but a quick search yields the following comment as a good summary:

https://developer.apple.com/forums/thread/712303?answerId=724093022#724093022

Since we are only using the task for the start() method, it's up to you to decide if we want it or not. I'm fine with either option.

navaronbracke avatar Dec 20 '23 10:12 navaronbracke