MuhammaraJS
MuhammaraJS copied to clipboard
Add test cases for text box underline, strikethrough, and highlight features
Had to make some modifications to lib/recipe/htmlToTextObjects.js and lib/recipe/text.js to make tests pass when
html: true
is set as an option when invoking .text()
Thank you very much for the pr
please run prettier on the changed files, prettier is complaining about not compliant files.
see: https://github.com/julianhille/MuhammaraJS/actions/runs/5426565804/jobs/9942641353?pr=311
thanks
one item to note, when the option
html: true
is set, text wrapped in html tags seem to be created on a new line. i still need to look into this. should i address the fix in this pr? or create another one for it?
i would suggest to start with it and then see. i'd use this as a base branch and then go from there, if its a small change related to this changes add it as commits, if its a complete seperate issue create a PR against this one.
sounds reasonable?
I changed base too see if this runs in fixed ci. Would you mind reading on that prepare V4 branch?
i don't mind reading from that branch. i see it was deleted though. which branch should i direct this pr to?
Ah. Dang. Sorry. Please reopen against dev.
Test to reopen.
I created a commit to address the text wrapped in html tags appearing on a new line. I've also added a test case for bolded text. There are some spacing issues to address now.
after_Add text with underline inside textbox.pdf before_Add text with underline inside textbox.pdf
sorry this branch has conflicts in the changelog, please rebase / merge dev
rebased. will work on spacing and may modify the changes a bit more
I will move the changes for the bug fix into its own branch and just keep the tests on this one