browser-run icon indicating copy to clipboard operation
browser-run copied to clipboard

going form 3.5.0 to 3.6.0 breaks http CORS requests and --mock

Open naugtur opened this issue 9 years ago • 3 comments

I didn't find out what's happening yet, but I saw a lot of tests failing https://github.com/naugtur/xhr/pull/156

I can reproduce running ok on 3.5.0 and breaking on 3.6.0

[edits]

  • also with latest
  • works fine in other browsers, it's about electron

Will report more as I go.

Any known issues?

naugtur avatar Mar 24 '17 11:03 naugtur

After digging in electron, I'm back here.

https://github.com/juliangruber/browser-run/commit/099da66622904747c891490252c76fc5541afdbf#diff-8e402bf78d4c5f8a4fb797709e5bc7a3L12

window.location is set to file:// protocol now, so:

  • mock option is now cross-domain
  • window.origin is null and correct CORS requests are not possible.

This is a big breaking change for my case.

naugtur avatar Mar 24 '17 13:03 naugtur

Probable duplicate of #135

TehShrike avatar Mar 24 '17 16:03 TehShrike

Protocol is fixed and things got better, but there's still something wrong. xhr tests work in 3.5.0, fail miserably later, then 10 failures occur on 4.0.2 I'll be looking into why that is happening.

naugtur avatar Apr 12 '17 19:04 naugtur