Julian Gilbey

Results 106 comments of Julian Gilbey

In `package.json`, we could also get rid of `promise-polyfill` (removed in e0ff7f8f1676e4a9913e202453dfcb33f2df4eab) and `fetch` (included in NodeJS and never imported). I´m not sure why we need `babel-loader` or `@babel/core` listed...

OK, I've managed to build the package with your PR, but the tests didn't all run. Here are the further things I've found: 1. It seems fine to remove `promise-polyfill`,...

Actually, I wrote: > 2. The file `.yarnrc` is ignored and should therefore be removed; the `--modules-folder` option is no longer valid. So the build should do (the equivalent of)...

> 1. It seems fine to remove `promise-polyfill`, `fetch`, `babel-loader` and `@babel/core`; at least doing so does not break any tests. Nope; `@babel/core` is required.

(And that forum post also has an analysis of the cause of the problem and a suggested resolution.)

Hi @matbe766, thanks! As far as I know, this still needs to be fixed (though I haven't had a chance to check recently). I have given a detailed analysis of...