react-npm-boilerplate icon indicating copy to clipboard operation
react-npm-boilerplate copied to clipboard

Prepublish is being deprecated in npm5

Open mattdufeu opened this issue 7 years ago • 3 comments

Apparently "prepublish" is changing in npm5 to only run on publish - http://blog.lholmquist.org/npm-prepublish-changes/.

To keep this boilerplate working in npm5, it appears to be as simple as change "prepublish" in package.json to "prepare".

I can raise a PR if you like?

mattdufeu avatar May 05 '17 19:05 mattdufeu

Hmm, so is it possible to leave both for now? Or is it backwards compatible somehow?

juliancwirko avatar May 05 '17 22:05 juliancwirko

Prepare seems to work fine in npm4, not sure about 3.

mattdufeu avatar May 06 '17 13:05 mattdufeu

I think the deprecation is only about changing the logic of prepublish script and not removing it completly. And this is good because we need it only when publishing the lib. But of course I need to test it when rebuilding the boilerplate.

juliancwirko avatar Aug 01 '17 15:08 juliancwirko