sgf-render icon indicating copy to clipboard operation
sgf-render copied to clipboard

Handle setup properties when using `--kifu`

Open julianandrews opened this issue 3 years ago • 2 comments

Right now, if there are any setup properties between the numbered moves in --kifu, the program ignores them.

I don't think there's a sensible way to handle those properties, but probably at least we should detect them and throw an error.

julianandrews avatar Sep 17 '21 22:09 julianandrews

I should add that the MN property is also problematic. Again, I don't think there's a sensible way to handle these properties in the middle of the numbered moves of a kifu. Probably from_node_in_collection should take first_move_number and kifu options, and throw an error if there are inapprorpriate properties.

julianandrews avatar Sep 21 '21 10:09 julianandrews

It might be cleaner just to run a pre-validation step that walks through the SGF.

julianandrews avatar Sep 21 '21 11:09 julianandrews