Julian Risch

Hi @yudataguy that's an interesting idea for an additional feature! Our core engineering team won't be able to work on it in the next two sprints but maybe you yourself...

@AlexGWOmron Thank you for this suggestion. I agree that it makes a lot of sense to check document_store and embedding dimensions before running the embedding calculations. Would you maybe like...

@awinml That's great to hear! You can find our general contributor guidelines here: https://github.com/deepset-ai/haystack/blob/main/CONTRIBUTING.md For this particular issue, I'd say in the beginning of the update_embeddings method, their should be...

Hi @sjrl if there are any unit tests that are currently not marked as unit tests, that's a change I would approve. At least some tests newly marked as unit...

Hi @sjrl just checking in on the status of this draft PR. What's your plan? Is there anything we can do to support you here? I'd suggest to limit the...

I'd prefer _Deactivate the falling test_add_eval_data_ for now to keep this PR smaller and merge faster. Refactoring and re-activating test_add_eval_data can be addressed in a separate PR. We also have...

I ran ``` !pip install farm-haystack[colab,preprocessing,elasticsearch,inference] from haystack.telemetry import send_event ``` in a fresh conda environment on MacOS but couldn't reproduce the issue. It works well for me with Apple...

Hello @vrunm first of all thank you so much for working on this pull request! The test revealed two remaining mypy issues: ``` haystack/components/rankers/lost_in_the_middle.py:62: error: Item "None" of "Optional[str]" has...

@vrunm The mypy issue occured because we ran `content.split()` in the code but `content` can be of type `string` or `None`. So I added a check that content is not...

@Koenlaermans Thank you for reporting this issue and investigating it! Your reasoning regarding how the reader trying to pop the prediction with ans_idx more than once leads to the error...