dns66 icon indicating copy to clipboard operation
dns66 copied to clipboard

Black (AMOLED) theme?

Open ghost opened this issue 8 years ago • 8 comments

Any chance that one can be implemented?

Also, I do have a question about the name. Why is it called dns66?

ghost avatar Dec 15 '16 22:12 ghost

It seems possible, but it's not like we look at the app much, so is it worth the effort?

Name - I don't know - It just happened. I went through some other names, ad related ones - but those did not work out. So I focused on the DNS part, and picked a random number after 42 did not really work out.

If you don't like that reason you can also think that the 66 comes from route 66 and symbolises freedom...

julian-klode avatar Dec 15 '16 22:12 julian-klode

So in other words this probably will not happen?

ghost avatar Dec 15 '16 23:12 ghost

I did not say that. I just have not taken a closer look at what that needs. There are basically three things that happen with wishes

  1. It's simple so I implement it
  2. It's interesting so I implement it
  3. Someone produces a reasonable pull request

It might be simple and it might also be interesting to try anyway. So it's looking good so far :)

julian-klode avatar Dec 15 '16 23:12 julian-klode

In my experience, adding a dark theme is pretty trivial. Just add a couple theme/styles that extend the dark appcompat theme instead of the light.darkactionbar theme.

Black theme on the other hand, is more effort to get working (although DNS66 seems to use pretty simple views so there's not that many different attributes to hunt down and change black). It's also harder to make a black theme look nice, because you have to balance "Making as much of the screen black as possible for maximum batter savings" with "Making it so users can tell different UI elements apart" (shadows aren't visible on black).

The second part of that makes it a more interesting problem, though :P

smichel17 avatar Mar 07 '17 20:03 smichel17

Bonus points (for my personal use) if it has integration with OnePlus' system-wide dark mode :) - Well, only if it's really easy (I can have some personal fun, right?).

Although that might make the choice tri-state again..

julian-klode avatar Mar 07 '17 20:03 julian-klode

UI Dark / Black / White / Default

julian-klode avatar Mar 07 '17 20:03 julian-klode

In Progress:

Black theme

That's the default DayNight theme in Night mode, with android:backgroundColor set to black, and

<color name="colorPrimary">#111111</color>
<color name="colorPrimaryDark">#000000</color>
<color name="colorPrimaryLight">#212121</color>
<color name="colorAccent">#C51162</color>
<color name="colorBackground">#000</color>

julian-klode avatar Apr 15 '17 00:04 julian-klode

We now have a dark theme in master. It's not a black theme, but it's a start.

julian-klode avatar Apr 15 '17 22:04 julian-klode