julia-vscode
Warnings about Mutex and other stuff
Just loading SymbolServer produces a large number of warnings. Not clear to me where they are coming from, but I think it has something to do with the recent changes:
ulia> using SymbolServer
[ Info: Precompiling SymbolServer [cf896787-08d5-524d-9de7-132aaa0cb996]
WARNING: Threads.Mutex is deprecated, use ReentrantLock instead.
likely near C:\Users\david\.julia\dev\SymbolServer\src\SymbolServer.jl:177
WARNING: Threads.RecursiveSpinLock is deprecated, use ReentrantLock instead.
likely near C:\Users\david\.julia\dev\SymbolServer\src\SymbolServer.jl:177
WARNING: Threads.Mutex is deprecated, use ReentrantLock instead.
likely near C:\Users\david\.julia\dev\SymbolServer\src\SymbolServer.jl:177
WARNING: Threads.RecursiveSpinLock is deprecated, use ReentrantLock instead.
likely near C:\Users\david\.julia\dev\SymbolServer\src\SymbolServer.jl:177
Copying some text from a PR here:
For the CI runs it is a bit annoying because it is a lot of output that has no information (I only pasted a short version, it is more like page after page). I don't think we could easily turn off deprecation warnings for the CI test runs, and we probably don't want to, given that we would to see legit deprecation warnings, right?
All these warnings also appear in the output channel in the VS Code UI, which is maybe the bigger issue. I think there we can just start the LS process without deprecation warnings, though, and that should solve it.
I think medium term we probably have to move the indexing of the stdlib and base out of the LS process and into the symbol server process as well, if we want to statically compile the LS process to make it start faster, and I assume at that point this problem would be automatically solved. Obviously that is a bigger project.
So maybe for now we just start the LS process in VS Code without dep warnings?
For now I'm putting this on the backlog because we could still improve, but no rush.