LanguageServer.jl icon indicating copy to clipboard operation
LanguageServer.jl copied to clipboard

WIP - add parsing/scoping capabilities for edits to single tokens

Open ZacLN opened this issue 4 years ago • 3 comments

An attempt to limit the amount of work done for static analysis. This identifies edits that can be made by altering terminal expr (i.e. those without child expr, such as identifiers and literals) that don't require us to run a full scopepass.

The (computational) savings should be significant, i.e. it should mean we're doing no unnecessary work when writing numbers, white space, editing identifiers or strings.

At the moment its delicate, it'll need a bit more work to ensure its robust enough.

ZacLN avatar Jan 25 '20 13:01 ZacLN

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@262ab2a). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #488   +/-   ##
=========================================
  Coverage          ?   35.07%           
=========================================
  Files             ?       21           
  Lines             ?     1628           
  Branches          ?        0           
=========================================
  Hits              ?      571           
  Misses            ?     1057           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 262ab2a...a81b137. Read the comment docs.

codecov[bot] avatar Jan 25 '20 14:01 codecov[bot]

I've put this on the backlog, or did you want to ship this with the next release?

davidanthoff avatar Jan 26 '20 22:01 davidanthoff

Lets wait on this one

ZacLN avatar Jan 27 '20 06:01 ZacLN