cache icon indicating copy to clipboard operation
cache copied to clipboard

Save cache even if failures

Open IanButterworth opened this issue 2 years ago • 5 comments

I think it makes sense to cache the depot even if there have been test failures.

Unfortunately it requires an upstream change https://github.com/actions/cache/pull/1242

IanButterworth avatar Nov 29 '23 16:11 IanButterworth

Alternatively, if we're willing to switch away from using a composite action we can use runs.post to perform the cache save (unfortunately, this is basically re-implementing actions/cache). It's rather unfortunate composite actions don't support the pre/post steps.

omus avatar Jan 02 '24 21:01 omus

https://github.com/actions/cache/pull/1242 has been merged and should be out in the next release

IanButterworth avatar Jan 16 '24 19:01 IanButterworth

It's out in the v4 release: https://github.com/actions/cache#v4

omus avatar Jan 17 '24 22:01 omus

Great. I don't immediately see why it warranted a major release..

IanButterworth avatar Jan 17 '24 22:01 IanButterworth