cache icon indicating copy to clipboard operation
cache copied to clipboard

add overridable `save-always` option

Open IanButterworth opened this issue 1 year ago • 8 comments

Closes #79

IanButterworth avatar Jan 18 '24 15:01 IanButterworth

Have you validated this is working? This failed CI run didn't seem to save the cache:

  • Failed job: https://github.com/julia-actions/cache/actions/runs/7572229335/job/20667038487?pr=107#step:11:123
  • Successful job: https://github.com/julia-actions/cache/actions/runs/7572229335/job/20666823090?pr=107#step:13:211

omus avatar Jan 19 '24 17:01 omus

It appears to be a CI glitch. CI had stalled and I did a partial re-run only of the failed jobs, which might not be valid for the test setup here.

There's a macos runner stalling here now too

IanButterworth avatar Jan 19 '24 18:01 IanButterworth

I've been meaning to test this on another repo with forced failure. I'll check before merge

IanButterworth avatar Jan 23 '24 17:01 IanButterworth

Yeah this is broken (never worked) upstream. PR to fix it https://github.com/actions/cache/pull/1325

IanButterworth avatar Mar 11 '24 17:03 IanButterworth

There's a staggering lack of review urgency on the upstream fix PR https://github.com/actions/cache/pull/1325

It makes me wonder if we should maintain a fork of actions/cache

IanButterworth avatar May 01 '24 13:05 IanButterworth

Based upon this comment the change to actions/cache@v4 should be considered breaking here. I think we'll be merging #123 first which means this change will be non-breaking for the upcoming release (v2).

omus avatar May 01 '24 16:05 omus

actions/cache are planning to remove the (non-working) save-always option which I think makes the goal of this PR impossible.

https://github.com/actions/cache/issues/1315#issuecomment-2163822166

IanButterworth avatar Jun 18 '24 15:06 IanButterworth

Marking as draft until (if/when) the blockers in https://github.com/actions/cache/issues/1315#issuecomment-2163822166 become unblocked.

DilumAluthge avatar Sep 26 '24 23:09 DilumAluthge