Jules Chéron
Jules Chéron
Thanks can you provide some benchmark with import time if you can along with this PR. Just a %timeit running import should be fine
I'd advise you to use Fraction for unit ratio. Thus unit powers should be reduced accordingly. Can you update your minimal example with definition for V rho cp D &...
xref https://github.com/hgrecco/pint/issues/1197#issuecomment-718356662, https://github.com/hgrecco/pint/issues/757#issuecomment-460753721 https://github.com/hgrecco/pint/issues/60#issuecomment-848040521 https://github.com/hgrecco/pint/issues/681#issuecomment-415907404. Last comment was about performance also, it would be good to have a benchmark on performance when using `Fraction`, seems weird it affects performance no...
CI failing cause of https://github.com/dask/dask/issues/9137 I'd be in favor of enforcing condition as something that is not a Quantity. It will be both safer for us to debug & avoid...
Agree with you raising is the cleanest but for consistency with other boolean / filter related function we can push this change.
Operations with unit 1 (dimensionless) are expected to be in radians. So `(-270 * ureg.deg) % 360` is equivalent to `(-270 * ureg.deg) % (360 * ureg.radians)` It produces the...
You can see here for an explanation why DimensionalityError raising are in place for floordiv & mod: https://github.com/hgrecco/pint/issues/943#issuecomment-638195938
I'm gonna close this, rationale is explained https://github.com/hgrecco/pint/issues/943#issuecomment-638195938. We provided workarounds, do not hesitate to reopen if something was not clear. ❤️
> Thanks, that does make sense, however it requires a lot of care of users of the system (it's very easy to write bugs). Also, it's not clear to me...
Using ureg["unit"] is a deprecated feature as you can see in the code base. https://github.com/hgrecco/pint/blob/09546b5f83fd5bc93809ee8880b69c328b699a60/pint/registry.py#L332-L337