Jörg Kubitz

modern light theme: inactive Console View Tab looks odd

6

reproduce: 1. disable "Show console" (automatically), switch to another view.  3. log something to Console 4. => "Console" becomes highlighted (bold, black) indicating pending output. With the new theme...

modern light theme: secondary views with wrong contrast

7

As far as i understand every View but the Editor is supposed to have low contrast but currently it is a wild mixture of shades Examples: JUnit Stack trace part:...

minor issue, just looks ugly: the replace-field is 2 pixel higher then the find-field:   @Wittmaxi

Very minor issue: On windows, default light theme: the inner border size of the overlay search is unbalanced if (and only if) used on a read only document like a...

StickyScrollingHandlerTest.testThrottledExecution fails on mac

6

https://download.eclipse.org/eclipse/downloads/drops4/I20240811-1800/testresults/html/org.eclipse.ui.editors.tests_ep433I-unit-macM1-java17_macosx.cocoa.aarch64_17.html ``` Wanted but not invoked: stickyLinesProvider.get( 400, org.eclipse.jface.text.source.SourceViewer@296023de ); -> at org.eclipse.ui.internal.texteditor.stickyscroll.StickyLinesProvider.get(StickyLinesProvider.java:47) However, there was exactly 1 interaction with this mock: stickyLinesProvider.get( 100, org.eclipse.jface.text.source.SourceViewer@296023de ); -> at org.eclipse.ui.internal.texteditor.stickyscroll.StickyScrollingHandler.calculateAndShowStickyLines(StickyScrollingHandler.java:151) at...

``` java.lang.AssertionError at org.junit.Assert.fail(Assert.java:87) at org.junit.Assert.assertTrue(Assert.java:42) at org.junit.Assert.assertTrue(Assert.java:53) at org.eclipse.e4.ui.tests.workbench.MMenuItemTest.testElementHierarchyInContext_HandledItem(MMenuItemTest.java:848) at java.base/java.lang.reflect.Method.invoke(Method.java:568) at org.eclipse.e4.ui.tests.rules.WorkbenchContextRule$1.evaluate(WorkbenchContextRule.java:62) ``` https://download.eclipse.org/eclipse/downloads/drops4/I20240813-0100/testresults/html/org.eclipse.e4.ui.tests_ep433I-unit-win32-java17_win32.win32.x86_64_17.html Could not reproduce that error locally. Starting the test locally takes 45 sec and...

Editor Tabs looks greyed out

12

in the past month the File names in the editor changed from black to grey or the used font got thinner then a pixel. Was that intentional? looks less readable...

exclude NON-binary files from file search by file extension

19

i just saw a a slow file search where it tried to search in *.png files I would say *.png files should be considered as binary. or not? 

for long texts i wish i could resize (and move) the overlay 

TestBug323833 fails on Mac since I20240729-1820

3

Both mac64 and macM: https://download.eclipse.org/eclipse/downloads/drops4/I20240813-0100/testresults/html/org.eclipse.core.tests.resources_ep433I-unit-mac64-java17_macosx.cocoa.x86_64_17.html https://download.eclipse.org/eclipse/downloads/drops4/I20240813-0100/testresults/html/org.eclipse.core.tests.resources_ep433I-unit-macM1-java17_macosx.cocoa.aarch64_17.html ``` org.opentest4j.AssertionFailedError: expected: but was: at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151) at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132) at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63) at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36) at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:31) at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:183) at org.eclipse.core.tests.resources.session.TestBug323833.test1(TestBug323833.java:85) at java.base/java.lang.reflect.Method.invoke(Method.java:568) at org.eclipse.core.tests.harness.session.SessionTestExtensionRemote.skipIfExecuteInHost(SessionTestExtensionRemote.java:61) at...