juju icon indicating copy to clipboard operation
juju copied to clipboard

[JUJU-1454] Re-write application_unit_test.go to use gomock generated mocks

Open jack-w-shaw opened this issue 3 years ago • 1 comments

This is in part to build a foundation to convert the JujuConnSuite test in this package

Checklist

  • [x] Code style: imports ordered, good names, simple structure, etc
  • [x] Comments saying why design decisions were made
  • [x] Go unit tests, with comments saying what you're testing
  • ~[ ] Integration tests, with comments saying what you're testing~
  • [ ] doc.go added or updated in changed packages

QA steps

Running the test suite should be enough

go test github.com/juju/juju/apiserver/facades/client/application

jack-w-shaw avatar Aug 03 '22 14:08 jack-w-shaw

Thanks for filling out the checklist. Could you please add a basic doc.go for the apiserver/facades/client/application package while you're in there?

benhoyt avatar Aug 03 '22 22:08 benhoyt

@hmlanigan I believe I have addressed your final concerns, ready for another glance

And yes, I intend to squash before merge

jack-w-shaw avatar Aug 12 '22 10:08 jack-w-shaw

LGTM perhaps @hmlanigan can give another glance.

basebandit avatar Aug 15 '22 13:08 basebandit

/merge

jack-w-shaw avatar Aug 15 '22 17:08 jack-w-shaw