juju-gui icon indicating copy to clipboard operation
juju-gui copied to clipboard

Expose shows clickable links before commit

Open merlijn-sebrechts opened this issue 7 years ago • 4 comments

Unexposed Charm:

image

When you click on expose, a new field appears with the Charm's public IP as a clickable link.

image

This makes me think that the application is exposed. I click on the link and my browser times out. This is because the application isn't exposed until I click "Commit Changes".

merlijn-sebrechts avatar Mar 22 '17 13:03 merlijn-sebrechts

Good catch! We should not show that as a link before the charm is actually exposed. Thanks.

frankban avatar Mar 22 '17 14:03 frankban

Note: this requires us to register and keep track of whether the app is exposed in Juju even after a change has been made but not committed by a GUI user.

frankban avatar Mar 23 '17 14:03 frankban

Hmmm. Normal human beings might imagine that clicking the button performs the action.

Also:

$ juju expose wordpress

would do that immediately, right?

There're a set of large-scale actions, where the [ commit changes ] , review and confirm, makes some workflow-sense.

There's another set of actions where, surely, I should be able to click and be done with it.

We only have one interaction model for performing changes in the GUI. So everything goes through the big button.

cassiocassio avatar Mar 29 '17 14:03 cassiocassio

@cassiocassio yes all CLI commands happen immediately.

There used to be a bug in the GUI in which the expose was triggered immediately but this was fixed in interested of having a consistent flow.

hatched avatar Mar 29 '17 15:03 hatched