gomaasapi icon indicating copy to clipboard operation
gomaasapi copied to clipboard

feat: add methods to put and update with files

Open skatsaounis opened this issue 1 year ago • 3 comments

This PR enables updating MAAS resources with files included.

Acts as an enabler for: PUT /MAAS/api/2.0/scripts/{name}: Update a script

Source: https://maas.io/docs/api

skatsaounis avatar May 02 '24 13:05 skatsaounis

Thanks for opening a pull request! Please follow the instructions here to ensure your pull request is ready for review. Then, a maintainer will review your patch.

@hpidcock @anvial

jujubot avatar May 02 '24 13:05 jujubot

Thanks for opening a pull request! Please follow the instructions here to ensure your pull request is ready for review. Then, a maintainer will review your patch.

@hpidcock @anvial

jujubot avatar May 02 '24 13:05 jujubot

NOTE: Post already accepts files but I kept the existing Put intact so that we will not break existing consumers of the gomaasapi. I could update Put directly if you like it more. Please let me know :slightly_smiling_face:

skatsaounis avatar May 02 '24 13:05 skatsaounis

Hi @manadart. I just added a new test to cover the function. Please take a look :slightly_smiling_face:

skatsaounis avatar May 28 '24 07:05 skatsaounis

@manadart Updated as per review. Please re-review :slightly_smiling_face:

skatsaounis avatar Jun 03 '24 07:06 skatsaounis

Hello @manadart . It's nice that this PR got merged. But in order to consume it properly it needs to be added to a new release. e.g., v2.3.0. Could you please create it in order to consume it from the https://github.com/maas/gomaasclient/? Thanks :slightly_smiling_face:

skatsaounis avatar Jun 10 '24 06:06 skatsaounis