MathGeoLib icon indicating copy to clipboard operation
MathGeoLib copied to clipboard

Why is the class "callstack" in the math directory?

Open LogicalError opened this issue 11 years ago • 3 comments

Title says it all

LogicalError avatar Jul 09 '14 11:07 LogicalError

Do you have a recommendation where to locate it better? I am hesitant to adding new directories in the source tree and the Math/ directory already contains all the logging functions as well (MathLog.h/.cpp) and callstack is very closely related to logging.

juj avatar Jul 09 '14 12:07 juj

I would probably put it into a separate directory called logging, it doesn't have anything (directly) to do with math ... ... why are you hesitant to add a new directory? is there a downside? ;)

LogicalError avatar Jul 09 '14 12:07 LogicalError

Having more directories means having more things to have to remember ("Did I have to #include "Math/Foo.h" or #include "Logging/Foo.h" or something else?"), and people have requested to not use absolute include directories so that users don't need to add multiple include directives i.e. -IMathGeoLib/ + -IMathGeoLib/Math + -IMathGeoLib/Geometry/. This means that the include directories in code have relative paths like #include "../../Math/Foo.h" and it looks a bit ugly.

I don't want to change existing code file locations, because that will definitely break code for all users if they need to change include files around. So it's simplest to keep the directory structure that currently exists, and not add new ones (unless there would be a large bulk of files to add in a new directory, that'd make organization much clearer).

juj avatar Jul 09 '14 13:07 juj