minio icon indicating copy to clipboard operation
minio copied to clipboard

fix: JfsObjects.CompleteMultipartUpload

Open prOOrc opened this issue 1 year ago • 1 comments

Description

Increased max size of part to 5Gb in CompleteMultipartUpload

Motivation and Context

I've caught bug when tested server side copy with rclone. Rclone has default copy cutoff 4.656Gi. During CompleteMultipartUpload gateway ignores size of parts and doesn't consider globalMaxPartSize (5GiB) and copies 1Gb max of each part.

How to test this PR?

Types of changes

  • [*] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Optimization (provides speedup with no functional changes)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ ] Fixes a regression (If yes, please add commit-id or PR # here)
  • [ ] Documentation updated
  • [ ] Unit tests added/updated

prOOrc avatar May 20 '24 15:05 prOOrc

@prOOrc Thanks for your feedback, but we no longer maintain gateway-1.1 branch, we have a better way to run gateway and support IAM, event notifications and other administrative features, release notes please check here . Of course this issue is also present in our new release, so can you provide this fix to the main branch in the juicefs repository? The code for the fix is the same.

zhijian-pro avatar May 23 '24 03:05 zhijian-pro

Moved to https://github.com/juicedata/juicefs/pull/4893

prOOrc avatar May 23 '24 19:05 prOOrc