juicefs-csi-driver icon indicating copy to clipboard operation
juicefs-csi-driver copied to clipboard

Fix check stuck mountpod when mountpod recreated

Open zxh326 opened this issue 10 months ago • 1 comments

when recreate mountpod, the new mountpod name may be equal the old one

if the pod.UID is different, it should not be considered a stuck mountpod

zxh326 avatar Apr 01 '24 03:04 zxh326

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 28.91%. Comparing base (ca7cece) to head (ec0fe13).

Files Patch % Lines
pkg/controller/pod_driver.go 25.00% 6 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #919      +/-   ##
==========================================
- Coverage   28.93%   28.91%   -0.02%     
==========================================
  Files          47       47              
  Lines        5986     5989       +3     
==========================================
  Hits         1732     1732              
- Misses       4087     4090       +3     
  Partials      167      167              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Apr 01 '24 03:04 codecov-commenter

之所以没看到检查和对比 uid 的代码,是因为该 pr 通过现场确认 pod status 的方式,来排除误伤拉起来的新 pod 的可能性,是这样吗?

那么假使这个新的 pod 也发生相同的 stuck terminating 情况,面对删除卡死,还能顺利 abort 吗?如果这方面没问题,那么 LGTM 自测通过后合并

timfeirg avatar Apr 07 '24 03:04 timfeirg

之所以没看到检查和对比 uid 的代码,是因为该 pr 通过现场确认 pod status 的方式,来排除误伤拉起来的新 pod 的可能性,是这样吗?

是的,之前是通过 uid 判断的,但是通过现场确认是否 delete 更符合直接一点。

那么假使这个新的 pod 也发生相同的 stuck terminating 情况,面对删除卡死,还能顺利 abort 吗?如果这方面没问题,那么 LGTM 自测通过后合并

可以的

zxh326 avatar Apr 07 '24 07:04 zxh326