fbrnch icon indicating copy to clipboard operation
fbrnch copied to clipboard

Better error when Bugzilla API key expired/invalid

Open QuLogic opened this issue 1 year ago • 3 comments

I tried to update a review after my Bugzilla API key expired. This failed with an inscrutable error message:

$ fbrnch create-review -S python-sphinx-autoapi.spec 
checking for existing reviews...
fbrnch: BugzillaJSONParseError "Error in $: endOfInput at '<!DOCTYPEHTML>'"

It should check the HTTP response code before trying to parse JSON.

QuLogic avatar Aug 19 '24 00:08 QuLogic

I will try to check on that - not sure if it is a problem in ghc-bugzilla-redhat.

juhp avatar Aug 19 '24 15:08 juhp

BTW I had opened https://bugzilla.redhat.com/show_bug.cgi?id=2306796 against Bugzilla

juhp avatar Sep 02 '24 05:09 juhp

The bugzilla.redhat.com fix is actually live now, though I had prepared an unpushed workaround for bugzilla-redhat

juhp avatar Sep 18 '24 06:09 juhp