Julien Herr comments

Results 369 comments of


                                            Julien Herr

TestNG fails to finish gracefully when executing tests with the dependsOnMethods attribute if an exception happens in ITestListener.onTestStart

Not sure but I think it was before/afterMethod

Allow users to access factory method params info

I'm working on it. I'm fighting against the issues of the legacy model.

assertEqualsDeep(Set, Set, String) fails when it shouldn't

Thanks for the report. Could you propose a fix in a pull request ?

Specifying `invocationCount`, `threadPoolSize` and `successPercentage` causes tests to always pass

@krmahadevan If you think it is a bad practice to mix these attributes, add a warning message they are used together. It will help users they are not using it...

Add checkerframework and errorprone

@vlsi Any feedback about the 2 tools and how I added them in the build (even if I was inspired by what you did on pg-driver)? @krmahadevan WDYT? They highlight...

Add checkerframework and errorprone

Thanks. > These highlight the problems in our code, but would it prevent TestNG from being used incorrectly by its consumers (especially the ones that use the TestNG apis to...

Add checkerframework and errorprone

Thanks for the feedbacks @vlsi ❤️

Add checkerframework and errorprone

Updated according to reviews. All issues are not fixed yet. Still 2 gradle issues: not succeeding in using the parameters plugin + not finding the way to merge package-info

Add checkerframework and errorprone

@vlsi Thanks for the review. I think your suggestion is a good strategy and I will make another PR with errorprone only. Any idea why I'm not able to use...

Multiple charging stations on the same power supply, limiting total current, peak shaving

You want smart charging. Duplicate of #520 and #552