Julien Herr comments

Results 378 comments of


                                            Julien Herr

Add Ability to support a new instance for every test method

@krmahadevan I think the feature request is still valid but not its first implementation. BTW JUnit5 added the 1 instance by class feature, we can add the 1 instance by...

API endpoints for automation and integration

This feature is awesome and open a lot of new options. Well done 👍

DataTransfer.req Data field quotation mark handling

It is not something nicely fixable from Steve: the specification doesn't say the way the data should be encoded and it will depend on the station itself. Some will accept...

Test Smell: it is not a good practice to write a return statement in the test case

@IsaakKrut I am uncertain if you will be able to test the modification. The desired outcome is for a warning message to be displayed if the test methods contain a...

Test annotated with `@Test(enabled=false)` and `@Ignore` should be reported as skipped

`@Ignore` is supposed to disable `@Test` thanks to an internal listener. The only expected behavior is that `@Ignore` on a class will disable enabled `@Test` on methods but `@Test(enabled=false)` won't....

Test annotated with `@Test(enabled=false)` and `@Ignore` should be reported as skipped

All the `@Ignore` logic is based on a listener. So, it sounds like an issue when listeners are involved. We should investigate and fix it on TestNG side.

Test annotated with `@Test(enabled=false)` and `@Ignore` should be reported as skipped

>That was what my sample was trying to show. @krmahadevan Right! I didn't realize your sample already highlights similar behavior between `@Ignore` and `@Test(enabled=false)`. > only available from `onBeforeClass` in...

Test annotated with `@Test(enabled=false)` and `@Ignore` should be reported as skipped

@krmahadevan @marcphilipp If it is possible, WDYT if we add an internal listener which notifies every discovered `ITestNGMethod`?

Test annotated with `@Test(enabled=false)` and `@Ignore` should be reported as skipped

I can't be present but @krmahadevan knows everything :)

search histogram x-axis labels are offset

The problem is on `NioEventLoopGroup group = new NioEventLoopGroup();` and in my real-life usage, I'm not the one who calls it. Are you able to create a `NioEventLoopGroup`?