camply icon indicating copy to clipboard operation
camply copied to clipboard

Published 20 hours ago • verified publisher icon juftin

Add going to camp support

Open acaloiaro opened this issue 2 years ago • 3 comments

This is nowhere near ready to merge. It is the crudest possible Going to Camp implementation. Nothing in this PR is final. I'm simply opening a draft to hold myself accountable.

There is a lot of cleanup work to be done here.

Fixes #94

acaloiaro avatar Jul 19 '22 02:07 acaloiaro

The current state of this PR Is that, due to each rec area having its own naming conventions for equipment, equipment matching needs to be improved.

acaloiaro avatar Aug 01 '22 00:08 acaloiaro

Hey @acaloiaro feedback is coming soon, I promise. I'm a little preoccupied with some work and personal things at the moment but I'll be following up here as soon as I can

juftin avatar Aug 23 '22 04:08 juftin

@juftin This PR is ready for a proper review.

Notable changes since you may have last seen it

  • --equipment and --equipment-length are separate.
  • I moved --provider on to the top-level of the CLI. Maybe this is too much of a breaking change. Happy to revert it if you think it doesn't make sense.

acaloiaro avatar Sep 11 '22 15:09 acaloiaro

I'm going to move forward and get this code staged to go to main. It's going to an intermediate release branch in the meantime where I can finally bring my testing changes up to date with it. :rocket:

juftin avatar Dec 22 '22 03:12 juftin