Juliana Fajardini Reichow
Juliana Fajardini Reichow
Updated description to include Redmine ticket. If we do accept these changes, the ticket number shall also be included as part of the commit messages (example: https://github.com/OISF/suricata/commit/3643b6ed4bed480f3d2608e38407d58709fdc3d8)
> > Updated description to include Redmine ticket. If we do accept these changes, the ticket number shall also be included as part of the commit messages (example: [3643b6e](https://github.com/OISF/suricata/commit/3643b6ed4bed480f3d2608e38407d58709fdc3d8)) >...
On another note: if/when there is more feedback to be incorporated, please open a new PR :) Another thing that we'll ask, before we can merge the final work, is...
Hello @fandigunawan did you get a chance to check the feedback left? :)
We're closing this PR as stale according to our [PR workflow policies](https://docs.suricata.io/en/latest/devguide/contributing/github-pr-workflow.html#github-pull-request-workflow). We do appreciate your interest and time in contributing to Suricata, so if you would be able to...
> Are you planning to resubmit soon? As I tried to improve on this one, I felt I was lacking some knowledge to write something that made sense. I'll close...
> Why are all the branches failing ? Should there be some `min-version: 8` ? I left it run with all Suri versions, because we have `flow.action` as a log...
> Need to be green for version 6 and 7 even if red for master, right ? Why, if 6 and 7 also have `flow.action`? Or more like in terms...
Replaced by https://github.com/OISF/suricata-verify/pull/1973
> > Considering the README description and the docs for this, could we have a rule with something like `app-layer-protocol:failed; app-layer-protocol:toserver` ? > > Do you mean rather `app-layer-protocol:failed,toserver;` ?...