Juliana Fajardini Reichow

Results 78 comments of Juliana Fajardini Reichow

> I don't understand the tx_id explanation, can you expand on it? What was happening before? What is the tx_id space? 0-N or 1-N? Pgsql's `tx_id` space is 1-N. When...

> Observation. > > In master branch without this patch: > > * by default, the `alert` record DOES NOT get the `pgsql` metadata > * with `--simulate-ips`, the `alert`...

> I'm initially curious why other protocols aren't having the same issue, or maybe they are. As this pattern used throughout. Maybe stateless parsers won't be affected by this? Afaik...

Closing this as I'm still investigating. I want to submit the next PR once we have a deeper understanding of what's going on, and whether the fix should include other...

> > documentation changes look good, provided that the code change is also approved. :) > > commit messages are a bit different from our conventions (cf https://docs.suricata.io/en/latest/devguide/codebase/contributing/code-submission-process.html#commits, item 6)....

> Signed the contribution agreement today. Can someone please review and approve the PR? Thank you. Hey there, I noticed that Victor tagged this with 8.0, so I imagine that...

CI failures seem unrelated, but I think it could be a good idea to rebase the code so we can see the CI all green again :)

Closing this for now as there's still work to be done and higher-priority issues got in the way. Will come back to this later.

> Hi @jufajardini, I can see that a label was removed at this [PR](https://github.com/OISF/suricata-verify/pull/1620), is that what causes workflow failure or because of wrong format for SV_BRANCH in the description....

> > Hi there, I removed the link because as all checks were passing in the SV PR, it seemed to me that that PR could be merged even if...