Jürg Wullschleger

Results 91 comments of Jürg Wullschleger

I think it will still log by default, according to what https://developer.android.com/reference/android/util/Log.html#isLoggable(java.lang.String,%20int) says. So I will change it to "verbose", so the logging is turned off by default, and the...

Yes, the lastest version of jetpack (https://developer.android.com/jetpack/androidx/releases/security#1.1.0-alpha04) says that the log message was removed, and references [b/185219606](https://issuetracker.google.com/issues/185219606). Which is marked as fixed. But I don't see what was changed.

I've now changed the logging to only log in verbose mode, https://github.com/google/tink/commit/cb67a3a9e3acce588cb00f7b2da384be1d48290a.

Sorry that nobody replied to this until now. Adding this code to Tink's code base would mean that we commit to supporting, and we can't do that. We don't have...

I think this has already been fixed, so I'll close this.

Thanks for this suggestion. I agree that we should do this.

In our tests, we are using pytype and not mypy. pytype is less strict. I tried to use mypy, and I got some errors that first would need to be...

I don't have time to work on this at the moment.

This is similar to https://github.com/tink-crypto/tink/issues/638. But that problem has been fixed. But note that under the hood we are using Android Keystore, which will fail if too many threads try...

I have now tested this by installing Conscrypt on startup, with: Security.addProvider(Conscrypt.newProvider()); With a single thread, this makes my test run about 20% slower, but with 10 threads in parallel,...