web-dev-projects icon indicating copy to clipboard operation
web-dev-projects copied to clipboard

Typos fixed

Open aditi-hinge opened this issue 2 years ago • 1 comments

I am building my portfolio and using your personal-portfolio repo to get some inspiration. As I am going through the code right now, I discovered some typos in the code because of which it was not functioning the way I wanted to. As I am using Prettier on VS code, it shows as a lot of changes have been made. Please ignore those. By far, I have made two main changes, which is, fixing the typos. I will explain them below.

  1. Fixed className File: Banner.js Line: 57 Change: <Row className="aligh-items-center"> changed to <Row className="align-items-center"> Result: Could align the content to the center

  2. Fixed 'projects' from NavBar File: NavBar.js Line: 63 Change: <Nav.Link href="#projects" className={activeLink === 'projects' ? 'active navbar-link' : 'navbar-link'} onClick={() => onUpdateActiveLink('projects')}>Projects</Nav.Link> changed to <Nav.Link href="#project" className={ activeLink === "projects" ? "active navbar-link" : "navbar-link" } onClick={() => onUpdateActiveLink("projects")} > Projects </Nav.Link> Result: Previously clicking on the "Projects" tab would not take me to the projects section, while "Home", "Skills" and "Let's connect" did. Changing href="#projects" to href="#project" fixed this issue.

So far I have encountered these two issues. Hope this helped and thank you.

aditi-hinge avatar Aug 30 '22 02:08 aditi-hinge

31/08/2022

Found another typo in Project.js to be fixed. Again, the code has been undergone change because of Prettier being activated on my VSCode.

The change has been done on Line 104.

The eventKey was wrongly named as 'section' instead of 'second'.
<Tab.Pane eventKey="second"> When this is fixed, the <p> tag is visible on the second tab.

aditi-hinge avatar Aug 31 '22 06:08 aditi-hinge