java-runtime-decompiler
java-runtime-decompiler copied to clipboard
judovana
Allow to pass additional (FS-like) classpath when compiling/overwriting
ssia
Contributor is utterly confused by this peculiar sequence of letters.
I guess it can be one global setting.
I was thinking of adding a field for this in the Overwrite dialog.
subject says it all :)
-- Mgr. Jiri Vanek @.***
---------- Původní e-mail ---------- Od: Prokop Tunel @.> Komu: pmikova/java-runtime-decompiler @. github.com> Datum: 24. 9. 2021 16:18:07 Předmět: Re: [pmikova/java-runtime-decompiler] Allow to pass additional (FS- like) classpath when compiling/overwriting (#139) "
" ssia " Contributor is utterly confused by this peculiar sequence of letters.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub (https://github.com/pmikova/java-runtime-decompiler/issues/139#issuecomment-926662600) , or unsubscribe (https://github.com/notifications/unsubscribe-auth/AAWFCS7O3RGG6PCLLLDKZRLUDSCBRANCNFSM5EQWPGZA) . Triage notifications on the go with GitHub Mobile for iOS (https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675) or Android (https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub) . "
Let's not complicate the Overwrite dialog more. My current ideas are going to reduce its usages for most of the usecases (eg. the one click button for compile/compile and upload - #138)
-- Mgr. Jiri Vanek @.***
---------- Původní e-mail ---------- Od: Prokop Tunel @.> Komu: pmikova/java-runtime-decompiler @. github.com> Datum: 24. 9. 2021 16:18:43 Předmět: Re: [pmikova/java-runtime-decompiler] Allow to pass additional (FS- like) classpath when compiling/overwriting (#139) "
" I guess it can be one global setting. " I was thinking of adding a field for this in the Overwrite dialog.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub (https://github.com/pmikova/java-runtime-decompiler/issues/139#issuecomment-926663089) , or unsubscribe (https://github.com/notifications/unsubscribe-auth/AAWFCSZHNZQCVMZJ73XP6ULUDSCD5ANCNFSM5EQWPGZA) . Triage notifications on the go with GitHub Mobile for iOS (https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675) or Android (https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub) . "
Let's not complicate the Overwrite dialog more. My current ideas are going to reduce its usages for most of the usecases (eg. the one click button for compile/compile and upload - #138
I agree to not complicate the Overwrite dialog, that's why we have #121. The idea behind "a field for this in the Overwrite dialog" was the concern of having this as a global setting in the app - I would think that there would be the need to have different additional classpaths for different VMs.
A compromise between our ideas would be to have the global setting as a default, but also have the dialog field to pass VM-specific additional classpaths.
Where I agree withyour concerns and with the compromise, the compromise bude kanon na vrabce.
in ideal world, the "cache" will be very very small, and super rarely used. It can be a bit expected, that such "cahce" will be indeed shared between vms.
-- Mgr. Jiri Vanek @.***
---------- Původní e-mail ---------- Od: Prokop Tunel @.> Komu: pmikova/java-runtime-decompiler @. github.com> Datum: 24. 9. 2021 17:16:03 Předmět: Re: [pmikova/java-runtime-decompiler] Allow to pass additional (FS- like) classpath when compiling/overwriting (#139) "
" Let's not complicate the Overwrite dialog more. My current ideas are going to reduce its usages for most of the usecases (eg. the one click button for compile/compile and upload - #138 (https://github.com/pmikova/java-runtime-decompiler/issues/138) " I agree to not complicate the Overwrite dialog, that's why we have #121 (https://github.com/pmikova/java-runtime-decompiler/issues/121). The idea behind "a field for this in the Overwrite dialog" was the concern of having this as a global setting in the app - I would think that there would be the need to have different additional classpaths for different VMs.
A compromise between our ideas would be to have the global setting as a default, but also have the dialog field to pass VM-specific additional classpaths.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub (https://github.com/pmikova/java-runtime-decompiler/issues/139#issuecomment-926708384) , or unsubscribe (https://github.com/notifications/unsubscribe-auth/AAWFCS22I6JCG7FHJ3KZ5WTUDSI25ANCNFSM5EQWPGZA) . Triage notifications on the go with GitHub Mobile for iOS (https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675) or Android (https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub) . "