Jason Judge

Results 289 comments of Jason Judge

I guess `$request->all()` (with the middleware) provides the parsed XML with all attributes removed, which may be sufficient for many use-cases. If an API wants to parse the XML in...

It seems that `$request->xml()` may not be a binary choice... array/stdClass/XMLDocoment?

That would be my assumption too. I think I'll put a check in my gateway: if it is an integer then it's minor units, and if a string with a...

Should V3 formalise it a little more? Perhaps accept a money object (with no ambiguities) as well as the current string?

@devnix there is a `setMoney()` method on the abstract request now: https://github.com/thephpleague/omnipay-common/blob/master/src/Common/Message/AbstractRequest.php#L366 The `setAmount()` method accepts major units as a string. Make sure you include the decimal point and minor...

Since `setAmount()` does not have any type-hints, then it does make sense to allow it to accept a `Money` object. I agree about a lot of the documentation. A lot...

So how do we go about capturing all the knowledge out there? There must be loads of people with small insights into how various parts of OmniPay work, but with...

I've created `fetchTransaction()` in the Helcim driver, and got that name by searching through what other drivers use. Fetching transactions is not one of the core methods of OmniPay, but...

If there is data to parse (e.g. `GET` and `POST` data) then the gateway driver will provide `complete*` methods. So on return to the merchant site, the application would do...

For server-to-server notifications use `acceptNotify()`. For the PayPal example you would use `completeAuthorize()` or `completePurchase()`. I'm not sure if there is a third case here? I do have a feeling...